Undefined index: und in mytheme_preprocess_page()

Question

I created a custom image field for a banner in one of my content type. I wish to display this banner in the page.tpl.php instead of node template. Here's my code in template.php:

function mytheme_preprocess_page(&$vars, $hook) {

     $vars['banner'] = ''; 
    if (!empty($vars['node'])) {
        $node = $vars['node'];

        if (isset($node->field_banner)) {
                // Render the image as a variable in the page template
           $vars['banner'] = theme_image_style(array('path' => $node->field_banner['und']['0']['uri'], 'style_name' => 'mybannerstyle', 'height' => '200', 'width' => '700'));
        } 
    }   

.....

and in the page.tpl.php, i coded:

    <?php if(!empty($banner)){print $banner;} ?> 

. This work perfectly in the node that has banner uploaded. But for nodes which have no banner, the following undefined messaged turn up:

Notice: Undefined index: und in mytheme_preprocess_page() (line 33 of /home/xxxxx/themes/mytheme/template.php).

I wonder how to solve this. Please advise. Thanks.

Answer 1

I think you should use $node->language over using 'und' when accessing your array. Second, to remove the warning you could simply do:

 if(isset($node->field_banner, $node->field_banner[$node->language])) {
   $vars['banner'] = theme_image_style(
        array(
          'path' => $node->field_banner[$node->language]['0']['uri'], 
          'style_name' => 'mybannerstyle', 
          'height' => '200', 
          'width' => '700')
   );
 } 

To access all images in your field you would do something like this:

 foreach($node->field_banner[$node->language] as $key => $value):
     $vars['banner']['images'][] = array(
          'path' => $node->field_banner[$node->language][$key]['uri'],
     );
 endforeach;

Answer 2

For a field, $entity->$field_name['und'] is not always defined. Instead of the code you are using, you should use the following code.

if (isset($node->field_banner)) {
  // Render the image as a variable in the page template.
  $field = field_get_items('node', $node, 'field_banner');
  $vars['banner'] = theme_image_style(array('path' => $field[0]['uri'], 'style_name' => 'mybannerstyle', 'height' => '200', 'width' => '700'));
} 

I would also consider using field_view_value(), instead of fields_get_items(), but the first function doesn't allow to customize the output, if not through the $display parameter. (See field_view_field() for a description of that parameter.)

field_get_items() and field_view_value() get the language ID from field_get_name(), which returns the correct value for the language to use for the field.

Answer 3

Hi Just change the line

'path' => $node->field_banner[$node->language]['0']['uri'], 

to

'path' => $node->field_banner[LANGUAGE_NONE]['0']['uri'], 

$node->language = LANGUAGE_NONE; is default in D7.

never use 'und' directly use LANGUAGE_NONE constant at place of und.