I'm new to services (and drupal 8!) and trying to figure out services. I think perhaps I'm just doing the create in an outdated way. What I want do is make my 'hello generator' a service and call it in another controller with the following:


namespace Drupal\db\Controller;

use Drupal\Core\Controller\ControllerBase;
use Drupal\db\DbServices\HelloGenerator;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\Response;

class DBController extends ControllerBase
private $helloGenerator;

public function __construct(HelloGenerator $x) {
    $this->helloGenerator = $x;
public function say($count) {
    $hello = $this->helloGenerator->getHello($count);

    return new Response($hello);

public static function create(ContainerInterface $container) {
    $x = $container->get('db.hello_generator');
    return new static ($x);


namespace Drupal\db\DbServices;

class HelloGenerator {

public function getHello($count) {
    $foo = 4 + 4 + 4;
    return $foo . ' ' . $count;



     class: Drupal\db\DbServices\HelloGenerator

  path: /db/says/{count}
    _controller: '\Drupal\db\Controller\DBController::say'
    _permission: 'access content'
  • You can follow document. It's correct way to call a service in a controller – MrD Aug 5 '16 at 17:46

There are 3 questions here:

  1. How to create a controller?
  2. How to create a service?
  3. How to use services in a controller?

1. Create a controller

1.1 Add a controller class - you did it. For others see Drupal documentation

1.2 Add a routing file - it looks like this is missing in your code:


  path: '/my/path'
    _controller: '\Drupal\my_module\Controller\MyController::myAction'
    _permission: 'access content'

see Drupal documentation

2. Create a service

2.1 Add a service class - you did it.

2.2 Add a routing file - you did it although it contains extra code that belongs to the routing file. This is all you need:


    class: Drupal\my_module\Service\MyService

see Drupal documentation

3. Use services in a controller

You did it. Here's a reference for others:

3.1 Override the create() method

The controller class inherits this method from class ControllerBase. Its role is to create the controller object. Watch the method argument: it is passed the services container. Extract the services you need and pass them to the constructor:

public static function create(ContainerInterface $container) {
    $my_service = $container->get('my_module.my_service');
    $other_service = $container->get('other_service');

    return new static($my_service, $other_service);

3.2 Initialise services in __construct()

public function __construct($my_service, $other_service)
    $this->my_service = $my_service;
    $this->other_service = $other_service;

3.3 Start using the services

  • 3
    I wish the official documentation was more in this style, or at least had a few overview articles that was. Short and concise with a generic example easily translated to the real application. – Nicolaj Feb 1 '18 at 9:59

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.