2

The Gates are open for Drupal.org Code Contributions, so now you can promote sandbox projects to full projects with releases if you have accepted the git terms of service.

But what is the actual use of the legacy Project Application issue queue (which is now named Drupal.org security advisory coverage applications?

I post this question because I have a module in revision there a some users that says that the code is OK, they made some suggestions and I made the changes until the last comment that says:

When a node Add is disabled, you should at minimum highlight which content type won't accept new content (in fact providing node edition instead).

This is a UX change that don't affect the security and don't affect the module functionalities. The module works fine without this. And now the module is promoted to full project this is an impediment to approve the module in the new Drupal.org security advisory coverage applications queue?

What are now the procedures to go ahead wit the revisions?

Disclosure: I'm the maintainer of the module Only One. I'm not looking for promotion, I just want to know how to finish the review process.

  • 1
    Usually a great way to draw attention to something like this is to back channel it through IRC to #drupalorg. It's not fair if your project is hanging in review purgatory while others can now just create the projects. – Kevin Mar 14 '17 at 14:09
  • Perhaps I misread the question - this seems better suited for drupal.org issue queue for clarification. – Kevin Mar 14 '17 at 14:11
  • @Kevin the project is promoted, but now how can I obtain the shield, because the project is reviewed, but a user want a UX change, this can stop the review process to obtain the shield, or how can I go ahead with the review process? – Adrian Cid Almaguer Mar 14 '17 at 14:13
  • 1
    This is an appropriate question for here. I have a partial answer written, but I need to check on a few things before I post it. Before I do, you can start to wade through drupal.org/node/2666584 – mpdonadio Mar 14 '17 at 15:17
1

The canonical reference for this is [Community Initiative Proposal] Project Applications Process Revamp.

As of 2017/03/14, most of the plan has been implemented on the back-end, but some of the documentation still needs to be updated and there are still a few things that are being fine tuned.

To directly answer your question, the old Project Application queue is being repurposed as the Drupal.org security advisory coverage applications queue.

There is currently a documentation page about how to apply for permission to opt into security advisory coverage.

In short, you need to go through the application process where your project is reviewed. Instead of being allowed to promote your project (which you can now do on your own), a successful application will result in the applicant being able to opt-into security team coverage (the meaning of the "git vetted" role is being changed).

The process is essentially the same, and the security advisory coverage application checklist has been updated. The review admins will block applications on

  • Licensing problems (including third-party code)
  • Security problems

An application can be blocked on other items in the checklist at admin discretion.

You can go ahead an work on the issues in your project's issue queue. Make sure you follow best-practices as outlined in (the page I can't find about being a responsible maintainer). If you haven't already, then make sure you have an application in the queue, and reviewers will use the latest -dev version of your code for evaluation.

Just keep in mind that the process changes that were just done were to allow project promotion; there is a still the human factor (and backlog) for the manual reviews for the security opt-in.

| improve this answer | |
  • Then the UX feature requested made by the reviewer don't impediment my project approval? – Adrian Cid Almaguer Mar 14 '17 at 20:25
  • @AdrianCidAlmaguer No, assuming it doesn't introduce a security problem. Admins will understand that modules now are being updated, many already use the git hash of the version they were looking at. Adding the UX improvement will also show that you are being a responsible maintainer. – mpdonadio Mar 14 '17 at 20:28
1

Apart from your actual question, you also posted a comment which contains this:

... the project is promoted, but now how can I obtain the shield?

Not sure if it will be a complete answer to your question, but your scenario here seems a variation of the question about "Why has my security shield for my new module on Drupal.org been removed?". Your variation now seems to be "Why has my security shield for my new module on Drupal.org not yet been added?" (or why is it not visible yet).

Here is part of my answer in that related question:

You need to create an official release, for at least 1 version of Drupal core that is supported. In your case, for D7, like a 7.x-1.0 version of your module. Shortly after doing so, your module will have the security shield.

I'm not sure (yet) about how long that Shortly actually may take, but I also noticed that on the revisions page of OnlyOne the most current timestamp is 13 Mar 2017 at 22:32 CET (which is less then 24 hours ago). Moreover, on its project page there is also Last modified: March 14, 2017 (which is today ...). But it could well be that with only a little patience (like until tomorrow?), you will automagically get the shield that you're looking for.

Update

Debugging is the art of taking away all possible causes ... about a day later it appears that for your module "a little patience" is not the solution (the shield still doesn't show up). Sorry.

| improve this answer | |
  • Maybe I'm a little confused, If I can get the shield only with the project release why we need a issue queue named: Drupal.org security advisory coverage applications drupal.org/project/projectapplications – Adrian Cid Almaguer Mar 14 '17 at 17:26
  • Maybe not an answer to your previous comment, but that's indeed a good question. And it confuses me too. Maybe worth another (separated) question here on D.A? BTW: I just discovered other "changes" to the behavior of project pages of project pages for some of my modules for which I last updated their project page about a year ago ... more fun on the way about that ... – Pierre.Vriens Mar 14 '17 at 17:40
  • I am 90% sure this answer is incorrect and tangential to the actual question, which is about the Project Applications queue being repurposed to the Drupal.org security advisory coverage applications queue. This has to do with what gets called the "git vetted" role, which is being repurposed to opt-in to security coverage. I don't have the full details yet, so I don't want to give out bad info (technically, I am a review admin, but inactive the last few months). – mpdonadio Mar 14 '17 at 19:33
  • Finally the project was approved and I see the shield now after I think 2 or 3 days. – Adrian Cid Almaguer Mar 20 '17 at 14:15

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.