hook_menu_alter not working

Question

I'm trying to alter tab names ("view current" and "edit current") but it is just not working.

function MY_MODULE_custom_menu_alter(&$items) {
    $items['node/%node/view']['title'] = t('View Event');
    $items['node/%node/edit']['title'] = t('Edit Event');
}

Module implementation is good. Cache is cleared. Tried it milion times, but still nothing!

Wondering is it possible that this code is being overriden somewhere, and how can I check that?

Answer 1

If your hook implementation is definitely being fired then it does seem likely that another module (or even a theme, potentially) is overriding your changes.

To ensure your module's implementation runs last, you can implement hook_module_implements_alter():

function MYMODULE_module_implements_alter(&$implementations, $hook) {
  if ($hook == 'menu_alter') {
    $group = $implementations['my_module'];
    unset($implementations['my_module']);
    $implementations['my_module'] = $group;
  }
}

If that isn't the problem, it might be something simpler...if your code is copied verbatim then you're setting the title twice for the same path. You might have meant

$items['node/%node/view']['title'] = t('View Event');

Or it might even be a combination of both of those.

Answer 2

The {menu_router} table contains the compiled result of hook_menu() and hook_menu_alter() implementations throughout your enabled modules. You can look at the entry for "node/%/edit" to see what's actually stored there for the "title" column; if it's "Edit Event", then your code is fine, and your problem is elsewhere.

If you suspect another hook_menu_alter() implementation is overriding you, you might try to grep for "node/%node/edit" throughout your codebase. You might also see if you have any Views page displays that are set with a path of "node/%/edit" - Views registers those routes programmatically using hook_menu_alter().

Answer 3

All right guys, I fixed it by installing Tab Name Tweaker module.

I still do not understand what is wrong with my code though. Note that Tab name tweaker module did not work all until I removed my custom hook_menu_alter(). That leads to conclusion that something must be wrong with this implementation:

    function MY_MODULE_menu_alter(&$items) {
        $items['node/%node/view']['title'] = t('Blah View');
        $items['node/%node/edit']['title'] = t('Blah Edit'); 
     }

I had also installed Modules Weight module, and tried putting my custom module at the end of list. No effect!

And even more strange, I use exactly the same code above to alter User profile tabs (in separate module), and it works there. Go figure out that! Insane!

Answer 4

Once I have the same problem and I solved it in an ugly way, but it works. I think that @Clive is right, some module is overriding your implementation so basically you have to update the module weight to run it at the end. To do it you can run:

update schema.system set weight = '99' WHERE name = "MODULE_NAME";

If this is working, you may look for some hooks to change the module weight.